On 2013-04-25, at 5:58 PM, Kazuya Mio wrote: > 2013/02/04 17:04, Kazuya Mio wrote: >> According to mke2fs man, we can create a filesystem on the mounted device when -FF option is specified. >> However, currently we have to specify -F option third to force mke2fs. This patch fixes the problem. >> >> Note that force mke2fs for mounted block device fails because mke2fs opens a device with O_EXCL flag. This work is contradictory to mke2fs man page, >> but I'm not sure it should be fixed or not. What do you think? > > Ted, please merge two patches if no problem is found. > > http://patchwork.ozlabs.org/patch/217838/ Out of curiosity, is formatting a mounted filesystem something that you are actually trying to do, or is this just a case of trying to make the mke2fs usage consistent with the man page? As for O_EXCL blocking mke2fs, this was changed by my patch in commit 732e26b98e5c. The only reason that this used to work was because a filesystem might _appear_ to be mounted if /etc/mtab was stale, but wasn't actually in use by the kernel. I don't think there is ANY good reason to allow mke2fs to succeed if the block device is _actually_ in use. Since 732e26b98e5c prevents mke2fs from actually formatting an in-use block device (at least on any modern kernel), I'm OK with this change, but wanted to understand the reasoning behind this. > http://patchwork.ozlabs.org/patch/217839/ I don't understand the second patch. If the user tries to format the /dev/loop device, then it is a "block device" and not really a "regular file" (i.e. the user probably knows what is going on). I don't think it is necessary to include the extra code and checking in this case. Do I misunderstand what your patch is doing? Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
