Still not quite...
On Thu 18-04-13 19:24:04, Ted Tso wrote:
> @@ -951,24 +971,17 @@ got:
>
> ext4_debug("allocating inode %lu\n", inode->i_ino);
> trace_ext4_allocate_inode(inode, dir, mode);
> - goto really_out;
> -fail:
> - ext4_std_error(sb, err);
> -out:
> - iput(inode);
> - ret = ERR_PTR(err);
> -really_out:
> brelse(inode_bitmap_bh);
> return ret;
>
> fail_free_drop:
> dquot_free_inode(inode);
> -
> fail_drop:
> - dquot_drop(inode);
> - inode->i_flags |= S_NOQUOTA;
> clear_nlink(inode);
> unlock_new_inode(inode);
> +out:
> + inode->i_flags |= S_NOQUOTA;
> + dquot_drop(inode);
The above two lines have to be swapped to preserve original ordering
which is actually important. Thanks.
Honza
> iput(inode);
> brelse(inode_bitmap_bh);
> return ERR_PTR(err);
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
