On Fri, Apr 5, 2013 at 4:01 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Apr 05, 2013 at 03:54:23PM -0700, Todd Poynor wrote:
> > Replace C division operators with div64_u64 for divides introduced in:
> > commit 503f4bdcc078e7abee273a85ce322de81b18a224
> > ext4: use atomic64_t for the per-flexbg free_clusters count
> >
> > Specific to the linux-3.0 backport of the upstream patch.
>
> Why is this specific? Why is this working differently in 3.0 from 3.4
> and newer?
Looks like 3.1 doesn't have this patch. The 3.2-stable backport of
this patch, for example, does not make some additional changes made in
the 3.0-stable backport, in addition to the upstream patch being
backported. These additional changes include converting
blocks_per_flex and flexbg_free_blocks from int to ext4_fsblk_t (a
64-bit type), probably as a part of these additional changes mentioned
in the commit message:
[Backported for 3.0-stable. Renamed free_clusters back to free_blocks;
fixed a few more atomic_read's of free_blocks left in 3.0.]
Perhaps the better fix is to revert those additional changes and let
the ext4 folks figure out what to do about the remaining atomic_reads.
> And care to cc: the ext4 developers/maintainers when sending ext4
> patches?
cc'ed now, apologies.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
