From: Tao Ma <boyu.mt@xxxxxxxxxx> Zach reported that if a dir is inlined, the offset is within the inode, while if we have done the conversion, the dir now will have a block offset or even a hashed pos. The good thing is that ext4 is also prepared to handle some situation that the dir is changed during many calls of getdents. This patch just increased the inode->i_version in dir conversion so that normal ext4 readdir codes can work properly to handle this issue. Reported-by: Zach Brown <zab@xxxxxxxxxx> Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx> --- fs/ext4/inline.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 9c09dd5..b1379fc 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1130,6 +1130,7 @@ static int ext4_finish_convert_inline_dir(handle_t *handle, EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) csum_size = sizeof(struct ext4_dir_entry_tail); + inode->i_version++; inode->i_size = inode->i_sb->s_blocksize; i_size_write(inode, inode->i_sb->s_blocksize); EXT4_I(inode)->i_disksize = inode->i_sb->s_blocksize; -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
