Re: [PATCH 2/7] ext4: fold ext4_generic_write_end() into ext4_write_end()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun 24-03-13 20:06:49, Ted Tso wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> 
> After collpasing the handling of data ordered and data writeback
> codepath, ext4_generic_write_end() has only one caller,
> ext4_write_end().  So we fold it into ext4_write_end().
> 
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> ---
>  fs/ext4/inode.c | 67 +++++++++++++++++++++++----------------------------------
>  1 file changed, 27 insertions(+), 40 deletions(-)
> 
...
> @@ -1105,7 +1123,7 @@ static int ext4_generic_write_end(struct file *file,
>  
>  	/*
>  	 * No need to use i_size_read() here, the i_size
> -	 * cannot change under us because we hold i_mutex.
> +	 * cannot change under us because we hole i_mutex.
  Typo added here. Otherwise the patch is fine. You can add
Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux