Re: [PATCH 1/2] ext4: Make ext4_block_in_group() much more efficient

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2013 at 11:24:10AM +0100, Lukas Czerner wrote:
> +	actual_group = (le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block) +
> +			block) >>
> +		       (EXT4_BLOCK_SIZE_BITS(sb) + EXT4_CLUSTER_BITS(sb) + 3);

The problem with this change is that you are assuming that the number
of blocks per group is equal to block_size * 8.  This is not always
the case; a nonstandard number of blocks per group can be set using
mke2fs's -g option.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux