On Tue, Mar 26, 2013 at 10:31:29AM +0100, Lukáš Czerner wrote: > > I have to admit I do not necessarily understand the reason for this. > Have you seen any specific problem with mutex not being locked in > the truncation path? This was really me being paranoid more than anything else and wanting to add more defensive programming. I was originally just going to add a comment, but decided it was better to put the assertion into the code. > Also, having mutex not locked in the truncation path is a bug so I > am not sure why we only do WARN_ON_ONCE() which can be easily missed > ? Can we do WARN_ON(), or WARN_ON_ONCE() + ext4_warning() ? Agreed, WARN_ON() is probably more appropriate here. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
