On Wed, Mar 20, 2013 at 09:07:27PM -0500, Eric Sandeen wrote: > On 3/20/13 8:09 PM, Dave Chinner wrote: > > On Tue, Mar 19, 2013 at 05:30:50PM +0800, Zheng Liu wrote: > >> From: Zheng Liu <wenqing.lz@xxxxxxxxxx> > >> > >> After finished test, temporarily fio config file should be removed. > >> > >> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx> > >> --- > >> 299 | 2 +- > >> 300 | 2 +- > >> 301 | 2 +- > >> 302 | 2 +- > >> 303 | 2 +- > >> 304 | 2 +- > >> 305 | 1 + > >> 7 files changed, 7 insertions(+), 6 deletions(-) > >> > >> diff --git a/299 b/299 > >> index 4305ead..9d0c32f 100644 > >> --- a/299 > >> +++ b/299 > >> @@ -32,7 +32,7 @@ echo "QA output created by $seq" > >> here=`pwd` > >> tmp=/tmp/$$ > >> status=1 # failure is the default! > >> +trap "rm -f $tmp.*; rm -f $tmp-$seq.fio; exit \$status" 0 1 2 3 15 > > > > Umm, wouldn't this be better: > > > > -trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 > > +trap "rm -f $tmp*; exit \$status" 0 1 2 3 15 > > > > Naming the files $tmp.fio would have worked too, but *shrug* > doesn't seem that critical. Still: > > > 2. You can safely create temporary files that are not part of the > > filesystem tests (e.g. to catch output, prepare lists of things > > to do, etc.) in files named $tmp.<anything>. The standard test > > script framework created by "new" will initialize $tmp and > > cleanup on exit. Good point. With that in mind, I think renaming the fio files is the right thing to do, not changing the traps to have to handle arbitrary tmp file names... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
