On Tue 19-03-13 17:36:17, Kazuya Mio wrote: > 2013/03/07 19:48, Jan Kara wrote: > >Then we properly mark bio should be submitted only if we are mapping last > >part of the mapped extent from the filesystem. Can you give this change a > >try (full patch with changelog attached)? > > Sorry for the late response. > After applying your patch, the problem I reported was fixed. > > One matter for concern is that submit_bio() is called twice per one buffer_head. > Because submit_page_section() calls dio_bio_submit() before adding > the old page (sdio->cur_page) and the current page to struct dio_submit. > Does it work as required? I'm not sure I understand. Looking into dio_send_cur_page() it seems may prematurely submit the bio if sdio->boundary is set - in that case we should probably first try to add the page to the bio and submit the bio only after that. Is that what you mean? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
