On Mon, Mar 18, 2013 at 11:10:51AM -0500, Eric Sandeen wrote: > > The test could do this too, right? > > _need_to_be_root > > and: > > if [ "$FSTYP" == "ext4" ]; then > ORIG_ZEROOUT_KB=`cat /sys/fs/ext4/$TEST_DEV/extent_max_zeroout_kb` > echo 0 > /sys/fs/ext4/$TEST_DEV/extent_max_zeroout_kb > fi > > and put it back to default in _cleanup: > > echo $ORIG_ZEROOUT_KB > /sys/fs/ext4/$TEST_DEV/extent_max_zeroout_kb > > That way we'd be testing seek hole correctness w/o being subject to > the vagaries in allocator behavior. Yeah, the question is whether it would be more acceptable to put ext4-specific hacks like this into the test, or to modify src/seek_sanity_test.c so that it writes the test block-size block using pwrite at offset blocksize*42 instead of offset blocksize*10. I had assumed putting hacks which tweaked sysfs tunables into the xfstest script itself would be frowned upon, but if that's considered OK, that would be great. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
