On Fri, Mar 15, 2013 at 01:53:58AM +0400, Andrey Sidorov wrote:
>
> Oh, thanks for pointing that! I was mostly reading v1.42 that is more
> than year old and missed the fact 1.42.7 has rbtree bitmap
> implementation.
> That explains why formatting bigalloc became slower compared to 1.42.
> In this case ffs/ffz seem like a right choice, I'll try them. I'll
> also try mirroring as it won't waste much RAM and might be faster.
As you'll discover fairly quickly, we haven't implemented ffs/ffz for
rbtree bitmaps yet. We've implemented find_first_zero for for
bitarrays (and for the generic bitmap framework in lib/ext2fs/bitops.h
and lib/ext2fs/gen_bitmap*.c), but not in lib/ext2fs/blkmap64_rb.c
yet. More critically for the mke2fs's use case in
convert_subcluster_bitmap, will be the find_first_set operation.
Adding this has been on my todo list for a while, but I just haven't
had the time. Note that test cases for this will be critically
important, especially if we start using them in correctness-critical
code such as e2fsck.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
