Re: [PATCH] Ext2: do not mark_inode_dirty to avoid BUG_ON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2013-3-14,上午7:09,Jan Kara <jack@xxxxxxx> 写道:

> On Tue 12-03-13 13:06:37, fanchaoting wrote:
>> From: Wang Shilong <wangsl-fnst@xxxxxxxxxxxxxx>
>> 
>> commit 8e3dffc651cb668e1ff4d8b89cc1c3dde7540d3b leads into
>> a regression that casue BUG_ON when unlinking inode.
>> 
>> Reported-by: tyhicks@xxxxxxxxxxxxx
>> Signed-off-by: Wang Shilong <wangsl-fnst@xxxxxxxxxxxxxx>
>  I ended up fixing the problem by the attached patch. It looks cleaner to
> me that way... Thanks for your fix anyway.

Sorry for delay reply, I am busy with my graduation project these two days.
However, your patch looks more reasonable than mine. 

Thanks very much to fanchaoting sending my patch out anyway.

Thanks,
Wang

> 
> 							Honza
>> ---
>> fs/ext2/balloc.c |    1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>> 
>> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
>> index 9f9992b..06d82fc 100644
>> --- a/fs/ext2/balloc.c
>> +++ b/fs/ext2/balloc.c
>> @@ -562,7 +562,6 @@ error_return:
>> 	if (freed) {
>> 		percpu_counter_add(&sbi->s_freeblocks_counter, freed);
>> 		dquot_free_block_nodirty(inode, freed);
>> -		mark_inode_dirty(inode);
>> 	}
>> }
>> 
>> -- 1.7.7.6 
>> 
>> 
>> 
>> 
> -- 
> Jan Kara <jack@xxxxxxx>
> SUSE Labs, CR
> <0001-ext2-Fix-BUG_ON-in-evict-on-inode-deletion.patch>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux