On 2/28/13 11:00 PM, Theodore Ts'o wrote: > When the system is under memory pressure, ext4_es_srhink() will get > called very often. So optimize returning the number of items in the > file system's extent status cache by keeping a per-filesystem count, > instead of calculating it each time by scanning all of the inodes in > the extent status cache. > > Also rename the slab used for the extent status cache to be > "ext4_extent_status" so it's obviousl the slab in question is created > by ext4. Certainly better than walking an arbitrarily long list. :) So: Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> I was wondering a couple things, though - 1) should this one be scaled by the vfs_cache_pressure sysctl? 2) Also, given that this is only for shrinker accounting, do we need the precision of the atomic counter? I see that quota uses a per-cpu counter. Would a percpu counter be any more efficient? I'll follow w/ a patch. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
