On Fri, Mar 01, 2013 at 10:29:46AM +0800, Zheng Liu wrote: [snip] > > > > + if (!ext4_es_is_written(es) && !ext4_es_is_unwritten(es)) > > > > + return; > > > > + > > > > + /* > > > > + * We don't need to worry about the race condition because > > > > + * caller takes i_data_sem locking. > > > Yes, and it is good place to assertion that we hold it. > > > > A BUG_ON(mutex_is_locked(&inode->i_mutex) will be added. > ^^^^^^^ > !mutex_is_locked(&inode->i_mutex) Sigh, it should be !rwsem_is_locked(&EXT4_I(inode)->i_data_sem). Sorry for the noisy. Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html