This seems to have been fixed in the ext4 master branch by commit http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=commitdiff;h=72ba74508b2857e71d65fc93f0d6b684492fc740 On Mon, Feb 25, 2013 at 3:32 PM, Jan Kara <jack@xxxxxxx> wrote: > On Mon 25-02-13 15:55:23, Jeff Mahoney wrote: >> If ext4_enable_quotas fails, it jumps to failed_mount7, which doesn't >> tear down the kobj. > The patch looks good. You can add: > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Honza > >> Cc: Aditya Kali <adityakali@xxxxxxxxxx> >> Cc: Jan Kara <jack@xxxxxxx> >> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx> >> --- >> fs/ext4/super.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> --- a/fs/ext4/super.c >> +++ b/fs/ext4/super.c >> @@ -3794,7 +3794,7 @@ no_journal: >> !(sb->s_flags & MS_RDONLY)) { >> err = ext4_enable_quotas(sb); >> if (err) >> - goto failed_mount7; >> + goto failed_mount8; >> } >> #endif /* CONFIG_QUOTA */ >> >> @@ -3813,6 +3813,10 @@ cantfind_ext4: >> ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem"); >> goto failed_mount; >> >> +failed_mount8: >> + kobject_del(&sbi->s_kobj); >> + kobject_put(&sbi->s_kobj); >> + wait_for_completion(&sbi->s_kobj_unregister); >> failed_mount7: >> ext4_unregister_li_request(sb); >> failed_mount6: >> >> -- >> Jeff Mahoney >> SUSE Labs >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > Jan Kara <jack@xxxxxxx> > SUSE Labs, CR -- Aditya -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
