On Mon, Feb 18, 2013 at 01:09:18AM +0800, Zheng Liu wrote:
> Hi Ted,
>
> There is a regression in 'dev' branch of ext4. I can trigger it by
> xfstests #269 in my desktop with a SSD when journal is disabled. I
> run this test case in 3.8-rc7 and it is ok. So I think this is a
> regression in 'dev' branch.
Hmm, I'm not seeing it on my auto run:
BEGIN TEST: Ext4 4k block w/ no journal Sun Feb 17 06:48:55 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 285 289
Failures: 274
END TEST: Ext4 4k block w/ no journal Sun Feb 17 08:01:06 EST 2013
Is this failing for you reliably? I've double checked all of my test
runs, and I've never seen test 269 fail for me with the standard 4k no
journal test run. Of course, I'm not using an SSD for my tests, so
that may explain the difference. I have seen the warning before, but
it's not a regression, so it on my "we need to examine this closely
but it's not yet a showstopper list":
127 [ 3553.596006] EXT4-fs warning (device vdb): ext4_da_update_reserve_space:360: ino 2628, allocated 1 with only 0 reserved metadata blocks (releasing 1 blocks with reserved 16 data blocks)
Attached below was my latest auto test run (this doesn't have your
latest extent status tree patches, since I ran it last night). It
*did* fail on test 269 with dioread_nolock, but in a different way
than what you reported. Instead of resulting in a corrupt file
system, it actually caused a kernel BUG to get triggered. (See
attached):
- Ted
[ 0.000000] Linux version 3.8.0-rc3-00054-g7b690cf (tytso@closure) (gcc version 4.7.2 (Debian 4.7.2-4) ) #895 SMP Sun Feb 17 02:42:02 EST 2013
FSTESTCFG is "all"
FSTESTSET is "-g auto"
BEGIN TEST: Ext4 4k block Sun Feb 17 02:43:08 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 068 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 280 285 289
Failures: 274 280
END TEST: Ext4 4k block Sun Feb 17 05:00:59 EST 2013
BEGIN TEST: Ext4 4k block w/nodelalloc, no flex_bg, and no extents Sun Feb 17 05:01:21 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 068 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 215 219 221 224 225 226 230 231 232 233 234 235 236 237 239 240 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 275 277 280 285 289
Failures: 255 280 285
END TEST: Ext4 4k block w/nodelalloc, no flex_bg, and no extents Sun Feb 17 06:48:53 EST 2013
BEGIN TEST: Ext4 4k block w/ no journal Sun Feb 17 06:48:55 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 285 289
Failures: 274
END TEST: Ext4 4k block w/ no journal Sun Feb 17 08:01:06 EST 2013
BEGIN TEST: Ext4 1k block Sun Feb 17 08:01:27 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 068 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 280 285 289
Failures: 274 280
END TEST: Ext4 1k block Sun Feb 17 11:36:11 EST 2013
BEGIN TEST: Ext4 4k block w/nodelalloc and no flex_bg Sun Feb 17 11:36:14 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 068 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 280 285 289
Failures: 223 274 280
END TEST: Ext4 4k block w/nodelalloc and no flex_bg Sun Feb 17 13:12:19 EST 2013
BEGIN TEST: Ext4 4k block w/metadata_csum Sun Feb 17 13:12:22 EST 2013
Ran: 001 002 005 006 007 011 013 014 015 020 053 062 068 069 070 074 075 076 079 083 088 089 091 100 105 112 113 117 120 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 192 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243 245 246 247 248 249 255 256 257 258 263 269 270 271 272 273 274 275 277 280 285 289
Failures: 274 280
END TEST: Ext4 4k block w/metadata_csum Sun Feb 17 14:49:53 EST 2013
BEGIN TEST: Ext4 4k block w/dioread_nolock Sun Feb 17 14:49:54 EST 2013
...
269 76s ...[50834.086303] BUG: unable to handle kernel NULL pointer dereference at (null)
[50834.088266] IP: [<c016fd26>] cwq_activate_delayed_work+0x1a/0x33
[50834.088266] *pdpt = 00000000263ec001 *pde = 0000000000000000
[50834.088266] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC
[50834.088266] Modules linked in:
[50834.088266] Pid: 6, comm: kworker/u:0 Tainted: G W 3.8.0-rc3-00054-g7b690cf #895 Bochs Bochs
[50834.088266] EIP: 0060:[<c016fd26>] EFLAGS: 00010046 CPU: 1
[50834.088266] EIP is at cwq_activate_delayed_work+0x1a/0x33
[50834.088266] EAX: 00000000 EBX: c2cc58bc ECX: 00001200 EDX: 00001200
[50834.088266] ESI: 00000000 EDI: 00000000 EBP: f64b7e94 ESP: f64b7e8c
[50834.088266] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[50834.088266] CR0: 8005003b CR2: 00000000 CR3: 29f77000 CR4: 000006f0
[50834.088266] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[50834.088266] DR6: ffff0ff0 DR7: 00000400
[50834.088266] Process kworker/u:0 (pid: 6, ti=f64b6000 task=f64b4160 task.ti=f64b6000)
[50834.088266] Stack:
[50834.088266] e9ae9400 00000000 f64b7ea4 c016fd74 d8bff644 00000000 f64b7efc c01712c9
[50834.088266] f64b45d0 f5427bc0 f5427bc0 0019a806 c0e453b0 c027a7e0 c0e45380 e9ae9400
[50834.088266] c0e452c0 c0e453f0 f6435540 c13975e8 c0f298e8 00000000 c0a73c8d 00000001
[50834.088266] Call Trace:
[50834.088266] [<c016fd74>] cwq_dec_nr_in_flight+0x35/0x69
[50834.088266] [<c01712c9>] process_one_work+0x2ce/0x330
[50834.088266] [<c027a7e0>] ? ext4_end_bio+0x1b1/0x1b1
[50834.088266] [<c01715ae>] worker_thread+0xff/0x18d
[50834.088266] [<c01714af>] ? rescuer_thread+0x15e/0x15e
[50834.088266] [<c0174d7f>] kthread+0x79/0x7e
[50834.088266] [<c019c55a>] ? trace_hardirqs_on+0xb/0xd
[50834.088266] [<c080fcb7>] ret_from_kernel_thread+0x1b/0x28
[50834.088266] [<c0174d06>] ? __kthread_parkme+0x59/0x59
[50834.088266] Code: c6 04 89 75 f0 75 c7 eb e6 89 19 58 5b 5e 5f 5d c3 55 89 e5 56 53 3e 8d 74 26 00 89 c3 e8 d1 f2 ff ff 89 c6 89 d8 e8 17 f9 ff ff <8b> 16 31 c9 89 d8 83 c2 08 e8 81 ff ff ff 0f ba 33 01 ff 46 4c
[50834.088266] EIP: [<c016fd26>] cwq_activate_delayed_work+0x1a/0x33 SS:ESP 0068:f64b7e8c
[50834.088266] CR2: 0000000000000000
[50834.088266] ---[ end trace 749b7ebbf8d88a3e ]---
Attachment:
log.201302170242.bz2
Description: Binary data
