Re: [PATCH 12/12] ext4: start handle at the last possible moment when creating inodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 09, 2013 at 04:53:52PM -0500, Theodore Ts'o wrote:
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 10bd6fe..943665b 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -725,6 +727,15 @@ repeat_in_this_group:
>  				   "inode=%lu", ino + 1);
>  			continue;
>  		}
> +		if (!handle) {
> +			BUG_ON(nblocks == 0);

I've changed this to be:

			BUG_ON(nblocks <= 0);

... since nblocks should (obviously) never be negative.

    	  	  	 	     	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux