On Fri, Jan 18, 2013 at 04:01:13PM +0800, Guo Chao wrote: > No body care about the effect of this assignment. > > Signed-off-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> > --- > fs/ext4/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > index b3717a3..e35ea3d 100644 > --- a/fs/ext4/namei.c > +++ b/fs/ext4/namei.c > @@ -714,7 +714,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, > *err = ERR_BAD_DX_DIR; > goto fail2; > } > - at = entries = ((struct dx_node *) bh->b_data)->entries; > + entries = ((struct dx_node *) bh->b_data)->entries; The 'at' variable seems to be used (in a if(0)'d code block) to check the results of the binary search against a slow linear search. Perhaps we should get rid of the if(0) hunk about 30 lines up? The 'at' variable itself could go too, since it seems to be an alias of "p - 1" and frame->at. --D > > if (!buffer_verified(bh) && > !ext4_dx_csum_verify(dir, > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
