On Thu, Jan 24, 2013 at 10:32:01PM -0500, Theodore Ts'o wrote: > On Fri, Jan 18, 2013 at 03:16:21PM +0800, Zheng Liu wrote: > > From: Zheng Liu <wenqing.lz@xxxxxxxxxx> > > > > After adding indirect punching hole feature, we need to enable it in fallocate. > > For this purpose, some sanity checks need to be adjusted. Currently we need to > > check FALLOC_FL_PUNCH_HOLE flag before other sanity checks. > > I've folded these two patches into one since the first patch in this > series since there won't be any way to exercise the new code paths > until we enable this in fallocate(), and it doesn't really change > existing code paths. If it did make huge changes in the normal code > path, it might be useful to keep the two commits separate, but that's > not the case here. > > Anyway, they look good so I've checked them into my tree. I'm > currently kicking off a test run to make sure there aren't any > problems except for the test 255 failure when testing w/o extents, but > I don't really anticipate any issues. Hi Ted, Sorry, my apology. I found a bug in indirect-based hole punching patch when I tried to create a new test case in xfstest. A patch has been sent out. Please look at it. Thanks, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html