On 2011-01-26, at 15:48, Wang Shilong <wangshilong1991@xxxxxxxxx> wrote:
> From: Wang Shilong <wangsl-fnst@xxxxxxxxxxxxxx>
>
> Because 'block + count < block' always comes to false, it is useless
> to have this check, just remove it.
This check can be true if the sum overflows the 32-bit variable it is stored in, so it is not useless...
Cheers, Andreas
> Signed-off-by: Wang Shilong <wangsl-fnst@xxxxxxxxxxxxxx>
> ---
> fs/ext3/balloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 22548f5..c557f22 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -507,7 +507,6 @@ void ext3_free_blocks_sb(handle_t *handle, struct super_block *sb,
> sbi = EXT3_SB(sb);
> es = sbi->s_es;
> if (block < le32_to_cpu(es->s_first_data_block) ||
> - block + count < block ||
> block + count > le32_to_cpu(es->s_blocks_count)) {
> ext3_error (sb, "ext3_free_blocks",
> "Freeing blocks not in datazone - "
> -- 1.7.11.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
