On Thu, Jan 24, 2013 at 05:30:43PM +0100, Lukas Czerner wrote:
> In two places we call WARN_ON() before we print out the debug message,
> however the custom is to print such messages before we call WARN_ON() so
> change that.
>
> Also use ext4_msg() instead of plain printk().
>
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
I was actually thinking about removing the WARN_ON entirely, or at
least suppressing it when the error begin returned from
ext4_map_blocks is EIO. The reason for that is the warning is causing
noise for automated log scanners, and if the problem is caused by a
hardware failure, there's no real point in dumping out a stack trace.
More generally, is there any reason why we need the stack trace at
all?
Also maybe we should use ext4_warning() instead of ext4_msg()?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
