On Fri, Jan 11, 2013 at 06:53:41PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
>
> This patch tries to refine the extent status tree. A prefix 'es_' is added to
> make code clearly.
I suggest the following commit description:
ext4: refine extent status tree
This commit refines the extent status tree code.
1) A prefix 'es_' is added to to the extent status tree structure
members.
2) Refactored es_remove_extent() so that __es_remove_extent() can be
used by es_insert_extent() to remove the old extent entry(-ies) before
inserting a new one.
3) Update and clarified comments.
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 564d981..0662369 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> + * Step2:
> + * In this step all extent status is tracked by extent status tree.
> + * Thus, we can first try to lookup a block mapping in this tree before
> + * find it in extent tree. Unwritten extent conversion also can be
> + * improved. Currently this conversion need to be done in a workqueue
> + * because this conversion can not be done in end_io function due to it
> + * needs to take i_data_sem locking in a irq context. After looking block
> + * mapping in extent status tree, we can first convert unwritten extent in
> + * extent status tree, call aio_comlete() and inode_dio_done() in end_io
> + * function, and don't need to be worried about expose a stale data.
Grammar nit: The last line should read:
"don't need to be worried about exposing stale data"
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
