On Wed, Jan 16, 2013 at 09:59:18AM -0500, Theodore Ts'o wrote:
> On Wed, Jan 16, 2013 at 08:04:56PM +0800, Zheng Liu wrote:
> > Yeah, it allows us to skip to the next data/hole directly if the extents
> > interface is used. But if we do that, we will need to handle
> > extent-based file and indirect-based file resptively like this.
> >
> > if (inode->i_flags & EXT4_EXTENTS_FL) {
> > ext2fs_file_ext_llseek_data();
> > ...
> > } else {
> > ext2fs_file_ind_llseek_data();
> > ...
> > }
> >
> > I am not sure whether it is too complicated or not for us. What do you
> > think?
>
> I'm not too worried about the performance issues for debugfs. But for
> clients who are accessing ext[234] using libext2fs and FUSE, they
> would probably notice in at least some circumstances. I'm not that
> worried about the complexity, but it's also not a high priority thing,
> either --- it's a "nice to have", not a "must have".
Understood. Let me try it.
Thanks,
- Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
