On Tue, Jan 15, 2013 at 11:33:31PM +0800, Zheng Liu wrote: > On Mon, Jan 14, 2013 at 07:37:12PM -0500, Theodore Ts'o wrote: > > If the user attemps to create a 512MB cluster, we need to adjust the > > defaults to avoid a 32-bit overflow of s_blocks_per_group. Also check > > to make sure that the caller of ext2fs_initialize() has not given a > > value of s_clusters_per_group that would result in an overflow of > > s_blocks_per_group. > > > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> > > The patch itself looks good to me. Feel free to add: > Reviewed-by: Zheng Liu <wenqing.lz@xxxxxxxxxx> Sorry, forgot to say that '-C' option in manpage will need to be modified from 256MB to 512MB if this patch is applied. Thanks, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html