On Fri, 28 Dec 2012 15:33:38 +0100, David Sterba wrote: > On Thu, Dec 20, 2012 at 06:09:35PM +0800, Miao Xie wrote: >> --- a/fs/fs-writeback.c >> +++ b/fs/fs-writeback.c >> @@ -1314,7 +1314,6 @@ void writeback_inodes_sb_nr(struct super_block *sb, >> bdi_queue_work(sb->s_bdi, &work); >> wait_for_completion(&done); >> } >> -EXPORT_SYMBOL(writeback_inodes_sb_nr); > > Why do you remove the export? writeback_inodes_sb is exported as well. As you said below, there is no user now. > Originally the _nr variant has been introduced for btrfs > (3259f8bed2f0f57c2fdcdac1b510c3fa319ef97e) and there are no other users > now, so from that point it would make sense. From the other side, the > change is not strictly necessary for this patch and keeps the writeback > API a bit more flexible. I vote for keeping it. Maybe you are right, I'll send out a new one. > Otherwise (for the btrfs part), > Tested-by: David Sterba <dsterba@xxxxxxx> Thanks for your test and review. Miao -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
