------- Original Message -------
From: Jan Kara <jack@xxxxxxx>
To: Chen Gang <gang.chen@xxxxxxxxxxx>
Cc: jack@xxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx;adilger.kernel@xxxxxxxxx; Theodore Tso <tytso@xxxxxxx>;jaegeuk.kim@xxxxxxxxxxx; dwmw2@xxxxxxxxxxxxx;torvalds@xxxxxxxxxxxxxxxxxxxx; linux-ext4@xxxxxxxxxxxxxxx;linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx;linux-mtd@xxxxxxxxxxxxxxxxxxx; reiserfs-devel@xxxxxxxxxxxxxxx
Sent: Mon, 31 Dec 2012 16:45:59 +0100
Subject: Re: [PATCH] fs/ext*,f2fs,jffs2,reiserfs: give comments for aclsize and count calculation
> I agree that defining a constant for this makes sence. Just please be
> more verbose with the comment. This is hardly readable for anyone not
> knowing what's going on in advance. Also braces around 4 are superfluous.
> Add something like the comment below before posix_acl_valid():
>
thank for your suggestions.
> /*
> * posix_acl_valid() makes sure ACL format is the following:
> * ACL_USER_OBJ ACL_USER*[1] ACL_GROUP_OBJ ACL_GROUP*[1] ACL_MASK[2] ACL_OTHER
> *
> * [1] Where * is the regexp sense of "0 or more times"
> * [2] If ACL_USER or ACL_GROUP is present, then ACL_MASK must be present.
> */
>
> Then add comment before definition of ACL_MAX_SHORT_ENTRY:
> /*
> * posix_acl_valid() makes sure that if there are <= 4 ACL entries, then
> * all of them are short. Otherwise exactly 4 entries are short ones and
> * other have full length. See comment before that function for exact ACL
> * format.
> */
I will send patch v2 which include the contents which you provide.
and also add Signed-of-by Jan Kara <jack@xxxxxxx>
thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
