Theodore Ts'o <tytso@xxxxxxx> wrote:
> On Thu, Nov 15, 2012 at 04:46:13AM -0000, Zheng Liu wrote:
>> --- a/debugfs/dump.c
>> +++ b/debugfs/dump.c
>> @@ -105,10 +105,11 @@ static void dump_file(const char *cmdname, ext2_ino_t ino, int fd,
>> {
>> errcode_t retval;
>> struct ext2_inode inode;
>> - char buf[8192];
>> + char buf[current_fs->blocksize];
> Note: this is a non-standard/non-portable GCC extension. The best way
> to fix this is to explicitly malloc the buffer and then free it before
> dump_file exits.
Er... isn't that also in C99? That should be portable enough.
Is there an actual compiler of interest that doesn't support it?
Here's a set of C99 conformance tests:
http://p99.gforge.inria.fr/c99-conformance/
Gcc, clang, icc, opencc and pcc all support VLAs.
Only tcc lacks support. Is tcc support an important goal?
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
