On Thu, Dec 27, 2012 at 12:04:36PM +0400, Dmitry Monakhov wrote: > On Thu, 27 Dec 2012 14:29:07 +0800, Zheng Liu <gnehzuil.liu@xxxxxxxxx> wrote: > > On Thu, Dec 27, 2012 at 03:27:04AM +0300, Alexander Beregalov wrote: [cut...] > > Now we try to take i_mutex lock before orphan list cleanup, although we don't > > need to take it in ext4_orphan_cleanup() because no one write this inode. > > WARN_ON_ONCE doesn't be removed because this warning could help us to avoid some > > ciritcal errors. > You can add Ack-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > > In fact this is my fault that we still not have autotest for that. > I'm think of add crash-test to xfstests which should trigger journal abort and forced > umount. Later test should mount FS which trigger journal_replay and orphan_cleanup. Cool! That would be great if this test case can be added in xfstests. :-) Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html