Re: [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 18-12-12 16:56:39, Guo Chao wrote:
> This macro, initially introduced by ext2 in v0.99.15, does not
> have any users from the beginning. It has been removed in later
> ext2 version but still remains in the code of ext3, ext4, ocfs2.
> Remove this macro there.
  Thanks. I've merged the patch into my tree. Since it's trivial, I guess
other fs maintainers won't mind.

								Honza
> 
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: "Theodore Ts'o" <tytso@xxxxxxx>
> Cc: Mark Fasheh <mfasheh@xxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx
> Cc: ocfs2-devel@xxxxxxxxxxxxxx
> Signed-off-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx>
> ---
>  fs/ext3/namei.c |    1 -
>  fs/ext4/namei.c |    1 -
>  fs/ocfs2/dir.c  |    1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index 890b894..88f64eb 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -36,7 +36,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE        (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static struct buffer_head *ext3_append(handle_t *handle,
>  					struct inode *inode,
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index cac4482..3f8c3d4 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -47,7 +47,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE	     (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static struct buffer_head *ext4_append(handle_t *handle,
>  					struct inode *inode,
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index 8fe4e28..fc12135 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -67,7 +67,6 @@
>  #define NAMEI_RA_CHUNKS  2
>  #define NAMEI_RA_BLOCKS  4
>  #define NAMEI_RA_SIZE        (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b)  (((c) * NAMEI_RA_BLOCKS) + (b))
>  
>  static unsigned char ocfs2_filetype_table[] = {
>  	DT_UNKNOWN, DT_REG, DT_DIR, DT_CHR, DT_BLK, DT_FIFO, DT_SOCK, DT_LNK
> -- 
> 1.7.9.5
> 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux