On Fri, 30 Nov 2012, Guo Chao wrote: > Date: Fri, 30 Nov 2012 14:41:43 +0800 > From: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> > To: tytso@xxxxxxx > Cc: linux-ext4@xxxxxxxxxxxxxxx > Subject: [PATCH 1/4] ext4: remove unsafe and unnecessary memset() > > We memset this page before checking whether it's valid. But we need > not memset zeroed page at all. > > Signed-off-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> > --- > fs/ext4/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index ad6cd8a..66a4e20 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -3206,7 +3206,6 @@ int ext4_calculate_overhead(struct super_block *sb) > ext4_fsblk_t overhead = 0; > char *buf = (char *) get_zeroed_page(GFP_KERNEL); > > - memset(buf, 0, PAGE_SIZE); > if (!buf) > return -ENOMEM; Good catch, thanks! Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
