ping On 22 November 2012 10:43, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > Hi Theodore, > > On 19 November 2012 21:53, Zheng Liu <gnehzuil.liu@xxxxxxxxx> wrote: >> On Mon, Nov 19, 2012 at 08:36:06PM +0530, Sachin Kamat wrote: >>> Hi Zheng, >>> >>> On 19 November 2012 19:09, Zheng Liu <gnehzuil.liu@xxxxxxxxx> wrote: >>> > On Mon, Nov 19, 2012 at 04:47:22PM +0530, Sachin Kamat wrote: >>> >> ext4_extents.h was included twice. >>> >> >>> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >>> >> --- >>> >> fs/ext4/super.c | 1 - >>> >> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >> >>> >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >>> >> index ad6cd8a..c8a6138 100644 >>> >> --- a/fs/ext4/super.c >>> >> +++ b/fs/ext4/super.c >>> >> @@ -50,7 +50,6 @@ >>> >> #include "xattr.h" >>> >> #include "acl.h" >>> >> #include "mballoc.h" >>> >> -#include "ext4_extents.h" >>> > >>> > Hi Sachin, >>> > >>> > Sorry, I don't find this duplicated code in mainline kernel 3.7-rc6. >>> >>> The duplicated code is available on the linux-next tree (20121115). >>> The second instance was added by the commit >>> "ext4: let ext4 maintain extent status tree" (commit id: 51865fda). >> >> Good catch. Sorry for my fault that introduces this duplicated code. >> The patch looks good to me. >> >> Regards, >> - Zheng > > This is just a simple patch to remove the include statement coded > twice in the file. > Please pick this up. > > -- > With warm regards, > Sachin -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
