Re: [PATCH 5/6] libext2fs: optimize rb_get_bmap_range() for mostly allocated bmaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 26, 2012 at 12:22:42PM +0100, Lukáš Czerner wrote:
> > +		if (pos > start+num)
> 
> Missing spacing around '+'.

I'll fix all of the spacing comments, thanks.

> Also I think that the condition should rather be:
> 
> 		if (pos >= start + num)

Yes.  I believe the case where pos = start + num gets caught later on
when we check the count variable, but it's cleaner/faster to bail out
here.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux