Hi, Zheng: On Mon, Nov 19, 2012 at 08:55:17PM +0800, Zheng Liu wrote: > From: Zheng Liu <wenqing.lz@xxxxxxxxxx> > > After adding indirect punching hole feature, we need to enable it in fallocate. > For this purpose, some sanity checks need to be adjusted. Currently we need to > check FALLOC_FL_PUNCH_HOLE flag before other sanity checks. > > Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx> > --- > fs/ext4/extents.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 7011ac9..b43b3e9 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4420,13 +4420,6 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; > unsigned int credits, blkbits = inode->i_blkbits; > > - /* > - * currently supporting (pre)allocate mode for extent-based > - * files _only_ > - */ > - if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) > - return -EOPNOTSUPP; > - > /* Return error if mode is not supported */ > if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) > return -EOPNOTSUPP; Checking these mode flags seems redundant here, VFS already checked them. Maybe you can remove it by the way. Regards, Guo Chao -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
