Hey Darrick,
I was looking at this code a bit more closely while applying the
revised version of this patch --- and this in particular raised a red
flag for me:
*(u32 *)desc.ctx = crc;
...
return *(u32 *)desc.ctx;
Does this raise any byte swapping issues? Looking at how the crc32
code in crypto/ works, I'm almost certain this is broken on big-endian
systems, and we need to add le32_to_cup() and cpu_to_le32() calls here.
Am I missing something?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
