On Tue, Oct 30, 2012 at 12:05:10PM -0500, Eric Sandeen wrote: > ext4_handle_release_buffer() was intended to remove journal > write access from a buffer, but it doesn't actually do anything > at all other than add a BUFFER_TRACE point, but it's not reliably > used for that either. Remove all the associated dead code. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > If this flies, I can do the same for ext3. > > diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h > index 56d258c..7177f9b 100644 > --- a/fs/ext4/ext4_jbd2.h > +++ b/fs/ext4/ext4_jbd2.h > @@ -254,13 +254,6 @@ static inline void ext4_handle_sync(handle_t *handle) > handle->h_sync = 1; > } > Particularly, I like code clean up, and the patch looks good Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> -- --Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html