On Tue, 30 Oct 2012 00:10:22 -0400 "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> wrote: > >>>>> "Darrick" == Darrick J Wong <darrick.wong@xxxxxxxxxx> writes: > > Darrick> This creates BDI_CAP_STABLE_WRITES, which indicates that a > Darrick> device requires stable page writes. It also plumbs in a sysfs > Darrick> attribute so that admins can check the device status. > > Might be nice to make the sysfs knob tweakable. Also, don't forget to > add a suitable blurb to Documentation/ABI/. It isn't at all clear to me that having the sysfs knob 'tweakable' is a good idea. From the md/raid5 perspective, I would want to know for certain whether the pages in a give bio are guaranteed not to change, or if they might. I could set the BDI_CAP_STABLE_WRITES and believe they will never change, or test the BDI_CAP_STABLE_WRITES and let that tell me if they might change or not. But if the bit can be changed at any moment, then it can never be trusted and so becomes worthless to me. At the very least it should only be possible to change it when there is no IO in flight. NeilBrown > > Feel free to add my Acked-by: >
Attachment:
signature.asc
Description: PGP signature
