Hi, >> >> Hi Adil, >> >> >> >> let me ask you something. How useful do you think those changes are ? >> >> Have you learned anything by creating those patches ? >> >> I am newbie. I just thought of starting with cleanup thing. I know >> that from functionality point of view, I am not adding anything but >> thought if it helps in coding guideline compliance and uniformity of >> code. >> Now I understand that this is not required. In future, I will avoid >> submitting such patches. > > So you've learned something :). But seriously such patches are > causing more problems than it solves. It's perfectly fine to clean > up the code in the area you're changing anyway, but making coding > style patches just for a sake of it is not usually useful. Moreover > it is not useful for you as well, because you're not going to learn > anything. I agree with you, it makes sense. > > There are plenty of real problem to be solved, but it actually > involves reading and understanding the code first. > > Just for example: > > - get familiar with xfstests > - there might still be problems with unified ext4 driver where > we might use options not suited for respective file system > - there are still issues with bigalloc > - I suspect that there will be some problems with file system >16TB > - recently there has been some reports from bigzilla.kernel.org > - or you can just read the code, trying to understand how it works > and soon or later you will find something to fix :) I am sure > about that. > > Maybe someone else have better suggestions... Thanks a lot Lukas for your suggestions. I'll definitely look into that as I really wanted to learn and contribute. I have seen bits and pieces in xfs but didnt get more documentation on implementation part, shall try to work upon that. More suggestions for newbie's like me, are welcome :) Thanks a lot. Rgds, Adil > > Good luck! > -Lukas > >> >> >> >> >> Just to clarify why I am asking such weird questions. It's not one of >> >> those sneer questions, I would really like to know. >> >>> linux-3.7-rc1/fs/ext4/balloc.c | 8 ++++---- >> > >> > The really sad thing is that this patch does not even apply because >> > the path is malformed. >> >> I am sorry, seems I am missing something. I tried with my local repo >> and it worked :( >> Its not the right place to ask, so I'll look what went wrong with the patches. >> >> Rgds, >> Adil >> >> > >> > -- >> > Thanks, >> > //richard >> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
