On Wed, Oct 03, 2012 at 09:11:47AM +0200, Lukas Czerner wrote: > The result of the bit shift expression in > '1 << sbi->s_log_groups_per_flex' can be undefined in the case that > s_log_groups_per_flex is 31 because the result of the shift is bigger > than INT_MAX. In reality this probably should not cause much problems > since we'll end up with INT_MIN which will then be converted into > 'unsigned int' type, but nevertheless according to the ISO C99 the > result is actually undefined. > > Fix this by changing the left operand to 'unsigned int' type. > > Note that the commit d50f2ab6f050311dbf7b8f5501b25f0bf64a439b already > tried to fix the undefined behaviour, but this was missed. > > Thanks to Laszlo Ersek for pointing this out and suggesting the fix. > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > Reported-by: Laszlo Ersek <lersek@xxxxxxxxxx> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
