Hi Zheng,
I was trying to apply these patches to the e2fsprogs pu branch, and as
a matter of course, I ran checkpatch on the patch series. The reason
why it's useful is because it finds stuff like this:
WARNING: trailing semicolon indicates no statements, indent implies otherwise
#156: FILE: lib/ext2fs/inline_data.c:567:
+ if (retval);
+ return pass;
ERROR: trailing statements should be on next line
#156: FILE: lib/ext2fs/inline_data.c:567:
+ if (retval);
> +int ext2fs_inline_data_header_check(ext2_filsys fs, ext2_ino_t ino)
> +{
> + struct ext2_inode_large *inode;
> + struct inline_data data;
> + errcode_t retval = 0;
> + int pass = 0;
> +
> + retval = ext2fs_get_mem(EXT2_INODE_SIZE(fs->super), &inode);
> + if (retval);
> + return pass;
This means the rest of ext2fs_inline_data_header_check() isn't getting
executed, since the "return pass;" statement would get executed
unconditionally. I didn't try it, but I suspect "make gcc-wall"
probably would have turned up this typo as well.
I'll fix this in my tree on the pu branch; I'm still looking over the
rest of the patches, but I thought it would be good to point this out
first.
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
