On Sat, 29 Sep 2012 00:49:04 -0400, "Theodore Ts'o" <tytso@xxxxxxx> wrote: > On Fri, Sep 28, 2012 at 07:44:07PM +0400, Dmitry Monakhov wrote: > > if (attr->ia_valid & ATTR_SIZE) { > > - if (attr->ia_size != i_size_read(inode)) > > + if (attr->ia_size != inode->i_size) { > > Why this change? Why are you not using i_size_read() here? Since we hold i_mutex no one is able to change i_size, and it is safe to access it directly. > > - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html