On Mon, Aug 27, 2012 at 02:27:32PM -0500, Eric Sandeen wrote: > When we have a filesystem with an orphan inode list *and* in error > state, things behave differently if: > > 1) e2fsck -p is done prior to mount: e2fsck fixes things and exits > happily (barring other significant problems) > > vs. > > 2) mount is done first, then e2fsck -p: due to the orphan inode > list removal, more errors are found and e2fsck exits with > UNEXPECTED INCONSISTENCY. > > The 2nd case above, on the root filesystem, has the tendency to halt > the boot process, which is unfortunate. > > The situation can be improved by not clearing the orphan > inode list when the fs is mounted readonly. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> I've applied this commit since I agree with Jan's observation that if the file system is mounted read-only, we should try to minimize changes to it if it contains errors. I have modified the commit description though: ext4: don't clear orphan list on ro mount with errors From: Eric Sandeen <sandeen@xxxxxxxxxx> If the file system contains errors and it is being mounted read-only, don't clear the orphan list. We should minimize changes to the file system if it is mounted read-only. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
