On 9/25/12 10:42 PM, Theodore Ts'o wrote: > On Mon, Sep 24, 2012 at 03:41:40PM -0300, Carlos Maiolino wrote: >> >> Some ext4_bread callers do not needed any changes either because they already >> had its own hole detector paths or because these are deprecaded (like >> dx_show_entries) > > BTW, dx_show entries isn't really deprecated; is debugging code which > is usually not compiled in, but it does get used from time to time by > developers who are debugging the directory hash tree code... > > So having it show the holes by printing a note that there _was_ a > whole is probably a good thing from a debugging point of view... I think what Carlos meant is that there are no callers in the tree... so even with debug options, it's not used. It takes a custom patch... Does it still work? :) -Eric > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html