Re: [PATCH] ext4: Don't calc checksum in update_backups in online resize.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 20, 2012 at 02:33:43PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@xxxxxxxxxx>
> 
> update_backups is used to backup all the metadata blocks, so we should
> not take it for granted that 'data' is pointed to a super block and use
> ext4_superblock_csum_set to calculate the checksum there. In case
> the data is a group descriptor block, it will corrupt the last group
> descriptor. And e2fsck will complain it.
> 
> As all the metadata checksum should already be OK when we do the backup,
> remove the wrong ext4_superblock_csum_set and it should be just fine.
> 
> Reported-by: "Theodore Ts'o" <tytso@xxxxxxx>
> Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx>

Applied.  Thanks for finding the fix!!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux