On Sun, Sep 09, 2012 at 09:27:11PM +0400, Dmitry Monakhov wrote: > fsync and punch_hole are the places where we have to wait for all > existing writers (writeback, aio, dio), but currently we simply > flush pended end_io request which is not sufficient. > Even more i_mutex is not holded while punch_hole which obviously > result in dangerous data corruption due to write-after-free. Hi Dmitry, Lukas already has a patch to take i_mutex locking before punching a hole. Just a reminding. :-) https://patchwork.kernel.org/patch/1247271/ Regards, Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html