On Tue, 4 Sep 2012 21:22:50 +0400, Dmitry Monakhov <dmonakhov@xxxxxxxxxx> wrote:
> If we have enough aggressive DIO readers, truncate will wait
> forever inside inode_dio_wait(). It is reasonable to disable
> nonlock DIO read optimization during truncate.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> ---
> fs/ext4/inode.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 709ec5a..e696f19 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4354,7 +4354,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
> if (attr->ia_valid & ATTR_SIZE) {
> if (attr->ia_size != i_size_read(inode))
> truncate_setsize(inode, attr->ia_size);
> + ext4_set_inode_state(inode, EXT4_STATE_DIOREAD_LOCK);
> inode_dio_wait(inode);
> + ext4_set_inode_state(inode, EXT4_STATE_DIOREAD_LOCK);
OOps, sorry ^^^^^^^^^^^^^^^ this is wrong
should be ext4_clear_inode_state()
> ext4_truncate(inode);
> }
>
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
