On 08/28/2012 08:34 PM, Ashish Sangwan wrote: > you can add 1 more. > In function ext4_mb_new_blocks(), change: > ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS); > to > ac = kmem_cache_zalloc(ext4_ac_cachep, GFP_NOFS); and remove > memset(ac, 0, sizeof(struct ext4_allocation_context)); from > ext4_mb_initialize_context(). got it, thanks, will include in the update version patch. > > On Mon, Aug 27, 2012 at 10:10 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote: >> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> >> >> Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset(). >> >> spatch with a semantic match is used to found this problem. >> (http://coccinelle.lip6.fr/) >> >> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> >> --- >> fs/ext4/mballoc.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
