On 8/10/12 1:21 PM, Theodore Ts'o wrote: > Add a short circuit check to ext4_mb_group_group() so that we don't > bother to load the block bitmap for a block group which does not have > any space available. (Or which does not have enough space until we > are in desperation mode, i.e., when cr == 3.) > > Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=45741 > Reported-by: mirek@xxxxxx > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> Looks ok to me; I think this just further optimizes what was done in 8a57d9d61a6e361c7bb159dda797672c1df1a691 ext4: check for a good block group before loading buddy pages correct? -Eric > --- > fs/ext4/mballoc.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 8eae947..3a57975 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -1862,6 +1862,12 @@ static int ext4_mb_good_group(struct ext4_allocation_context *ac, > > BUG_ON(cr < 0 || cr >= 4); > > + free = grp->bb_free; > + if (free == 0) > + return 0; > + if (cr <= 2 && free < ac->ac_g_ex.fe_len) > + return 0; > + > /* We only do this if the grp has never been initialized */ > if (unlikely(EXT4_MB_GRP_NEED_INIT(grp))) { > int ret = ext4_mb_init_group(ac->ac_sb, group); > @@ -1869,10 +1875,7 @@ static int ext4_mb_good_group(struct ext4_allocation_context *ac, > return 0; > } > > - free = grp->bb_free; > fragments = grp->bb_fragments; > - if (free == 0) > - return 0; > if (fragments == 0) > return 0; > > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
