On Tue, Aug 07, 2012 at 02:50:53PM -0400, Theodore Ts'o wrote:
> On Tue, Jul 31, 2012 at 07:47:59PM +0800, Zheng Liu wrote:
> > +struct ext2_ext_attr_ibody_header {
> > + __u32 h_magic;
> > +};
> > +
>
> I've searched through the entire patch series, and I don't find any
> usage of h_magic, and in fact the only place this structure definition
> is used is in ext2fs_get_inline_xattr_pos().
>
> So that's a bit worrying; if this is a magic number, then it should be
> checked (and an error returned if the magic number is not what we
> expect it tobe). Add checks into e2fsck would also be a really good
> idea. Also, what is the value that h_magic is epxected to be? It
> needs to be defined here.
>
> It's also clear from looking at this function that this patch
> significantly changes the layout of the extended attribute block of
> data. It would be a really good idea to add some ascii art to
> document exactly what is going on. A diagram so it's obvious to
> future developers about the data layout is really needed.
Thanks, I will fix it.
Regards,
Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
