On 2012-08-11, at 1:26 PM, Theodore Ts'o wrote: > On Fri, Aug 10, 2012 at 09:22:39PM -0600, Andreas Dilger wrote: >> >> In our patch, it returns EFBIG, since it isn't really a case of >> being out of space for blocks or inodes. > > I agree, EFBIG seems to be a better errno. > > How did you configure the directory size limit, BTW? Did you use a > mount option, if so, what did you name it? It was configured via /sys/fs/ext4/{dev}/max_dir_size, but the units were bytes instead of kbytes. Not many sites use this value, so if it needs to be renamed .../max_dir_size_kb it wouldn't be fatal - we could modify our patch to allow both, and print a deprecation message if the old one is used. It will likely still be a few years before distros are running 3.6 (or whatever kernel this patch is included in). At least we wouldn't have to carry that patch in perpetuity. Cheers, Andreas -- Andreas Dilger Whamcloud, Inc. Principal Lustre Engineer http://www.whamcloud.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html