On Wed, Jul 25, 2012 at 07:53:34PM +0530, Ashish Sangwan wrote: > While performing punch hole for an inode, i_disksize is not changed. > So, there is no need to add the inode to orphan list. > > Signed-off-by: Ashish Sangwan <ashish.sangwan2@xxxxxxxxx> > Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx> Acked-by: Zheng Liu <wenqing.lz@xxxxxxxxxx> Regards, Zheng > --- > fs/ext4/extents.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 91341ec..3e902f9 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4801,9 +4801,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) > if (IS_ERR(handle)) > return PTR_ERR(handle); > > - err = ext4_orphan_add(handle, inode); > - if (err) > - goto out; > > /* > * Now we need to zero out the non-page-aligned data in the > @@ -4889,7 +4886,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) > up_write(&EXT4_I(inode)->i_data_sem); > > out: > - ext4_orphan_del(handle, inode); > inode->i_mtime = inode->i_ctime = ext4_current_time(inode); > ext4_mark_inode_dirty(handle, inode); > ext4_journal_stop(handle); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html